[AKS] Fix that cli doe not fail when user only specifies Windows password #13418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrownj
reviewed
May 9, 2020
Collaborator
|
AKS |
arrownj
approved these changes
May 11, 2020
Member
|
hi @arrownj can this PR been merged now? |
Member
Author
|
@arrownj I have updated the PR but those 2 pylint checks still fail with below 2 errors. It seems like no related to my PR. Do you have any idea? |
derekbekoe
added a commit
to derekbekoe/azure-cli
that referenced
this pull request
May 18, 2020
* 'dev' of https://github.com/Azure/azure-cli: (85 commits) {Monitor} az monitor autoscale profile show: bug fix (Azure#13515) [Monitor] az monitor diagnostic-settings create: support --export-to-specific-resource argument (Azure#13544) [aro]Add tests for generate_random_id function (Azure#13522) [ARO]Change CLIError to correct flag for --worker-vm-disk-size-gb (Azure#13439) [Packaging] Add Ubuntu Focal Package (Azure#13491) Update parse_zone_file.py (Azure#13377) {Release} Upgrade to Azure CLI 2.6.0 (Azure#13542) fix (Azure#13511) {Resource} Add example to tell how to pass array to --parameters (Azure#13510) [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function (Azure#13481) {Network} az network nic create: Refine help message (Azure#13513) [Storage] az storage blob sync: Fix the incorrect error message when azcopy cannot find the installation location (Azure#9576) (Azure#13104) Support --connect-string for az storage blob sync (Azure#13135) Modify the deprecate information for deployment operation (Azure#13390) [AppService] Onboard local context for app service (Azure#12984) {Monitor} az monitor metrics alert: refine severity explanation (Azure#13512) [IoT Hub] Support for 2020-03-01 API and Network Isolation commands (Azure#13467) [Compute] az vm list-skus: Update --zone behavior, return all type skus now (Azure#13470) Fix that cli doe not fail when user only specifies Windows password (Azure#13418) {ACR}: expose --expiration from token commands (Azure#13451) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will help users to validate whether windows-admin-username is set when they want to create a cluster with Windows agent pools.
For example, a user only sets windows-admin-passowrd so a cluster without specifying Windows admin username and password will be created.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.