[SQL] az sql mi create, az sql mi update: Add --tags parameter to support resource tagging
#13479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
add to S169 |
v-nestan
changed the title
az sql mi create, az sql mi update: Add --tags parameter to support resource tagging
jaredmoo
approved these changes
May 13, 2020
Juliehzl
reviewed
May 14, 2020
Juliehzl
reviewed
May 14, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
petrajkogit
approved these changes
May 14, 2020
Collaborator
|
add to S170 |
Collaborator
|
add to S171 |
Contributor
|
any update? |
Contributor
|
can you take a look at test failures? |
Juliehzl
reviewed
Jul 6, 2020
Juliehzl
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for managed instance tagging on create and update.
That is achieved by adding --tags parameter to 'az sql mi create' and 'az sql mi update'.
Once managed instance is created, tags can be
az sql vm update --set tags.tagName=tagValue
az sql vm update --remove tags.tagName, or
az sql vm update --tags ""
az sql vm update --tags tagName1=tagValue1 tagName2=tagValue2
Repair item links
https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/709400
https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/709401
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.