[Batch] Update to API Version 2020-05-01 #13796
Conversation
|
@myronfanqiu where is the CredScan omit file for the CLI? Seems to be catching temporary keys in the test yamls that it didn't before (cleaned up as part of test automation). |
|
add to S171 |
bgklein
force-pushed
the
brklein/mgmt-mar
branch
2 times, most recently
from
7df0456 to
07b1eb2
Compare
|
@jsntcy please review as early as possible. I would like to address any concerns as soon as possible to not delay other work |
|
What does it mean |
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py
Outdated
Show resolved
Hide resolved
.../network/private_link_resource_and_endpoint_connections/resource_providers/batch_provider.py
Outdated
Show resolved
Hide resolved
.../network/private_link_resource_and_endpoint_connections/resource_providers/batch_provider.py
Outdated
Show resolved
Hide resolved
.../network/private_link_resource_and_endpoint_connections/resource_providers/batch_provider.py
Outdated
Show resolved
Hide resolved
|
Yes, Fan and I added some comments, please take a look. In reply to: 638317849 [](ancestors = 638317849) |
Just that private endpoint/link is a networking feature that each RP has to add support for. We are adding Batch support to a Networking feature. It should be classified as Batch so customers know that it is now added, but could also be classified as networking additionally |
|
@jsntcy Please take a look at this PR. |
9 participants
Description
Batch has added a new API version (already released as Python SDK). These new features are part of JEDI deliverables.
History Notes
[Batch/Network] az network private-link-resource: Add support for the Microsoft.Batch batchAccount resource
[Batch/Network] az network private-endpoint-connection: Add support for the Microsoft.Batch batchAccount resource
[Batch] az batch account create: Added new parameter
--public-network-access[Batch] az batch account create: Added new parameter
--identity-type[Batch] az batch account set: Added new parameter
--identity-type[Batch] BREAKING CHANGE: az batch pool create: When creating a pool using a custom image, the --image property of can now only refer to a Shared Image Gallery image.
[Batch] BREAKING CHANGE: az batch pool create: When creating a pool with --json-file option and specifying a networkConfiguration, the publicIPs property has moved in to a new property publicIPAddressConfiguration. This new property also supports a new ipAddressProvisioningType property which specifies how the pool should allocate IP's and a publicIPs property which allows for configuration of a list of PublicIP resources to use in the case ipAddressProvisioningType is set to UserManaged
This checklist is used to make sure that common guidelines for a pull request are followed.
[X ] The PR title and description has followed the guideline in Submitting Pull Requests.
[X ] I adhere to the Command Guidelines.