{Identity} Fix logout #13822
Merged
{Identity} Fix logout #13822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom and
qianwens
as code owners
qianwens
approved these changes
Jun 4, 2020
| return self._msal_app.get_accounts(user_or_sp) | ||
| except ValueError: | ||
| pass | ||
| accounts = self._msal_app.get_accounts(user_or_sp) |
Member
There was a problem hiding this comment.
why remove the try-catch? it throws an exception if the user does not exist which is not handled in the logout function
Member
Author
There was a problem hiding this comment.
ValueError is thrown due to the incorrect authority given to PublicClientApplication. If the username is not found, [] will be return.
Collaborator
|
add to S171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix regression introduced in #13567. Use MSAL-style
authorityto build thePublicClientApplication.Testing Guide