Skip to content

Conversation

@mimckitt
Copy link
Contributor

@mimckitt mimckitt commented Jun 15, 2020

Description

We have changed the term "Low Priority" to "Spot". We have already updated the PowerShell commands and now we need to rename the two items in CLI from "Low Priority" to "Spot"

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@mimckitt mimckitt requested review from arrownj and qwordy as code owners June 15, 2020 19:37
@mimckitt mimckitt changed the title Update _params.py Update _params.py to adjust "Low Priority" to "Spot" Jun 15, 2020
@yonzhan yonzhan added this to the S171 milestone Jun 15, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 15, 2020

Compute

@mimckitt mimckitt changed the title Update _params.py to adjust "Low Priority" to "Spot" Update _params.py Jun 16, 2020
@mimckitt mimckitt closed this Jun 16, 2020
@mimckitt mimckitt reopened this Jun 16, 2020
@qwordy qwordy changed the title Update _params.py {Compute} Update help message Jun 16, 2020
@qwordy
Copy link
Member

qwordy commented Jun 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@qwordy
Copy link
Member

qwordy commented Jun 16, 2020

Thank you for the contribution!

@qwordy qwordy changed the title {Compute} Update help message {Compute} Update help message - changed the term "Low Priority" to "Spot" Jun 16, 2020
@qwordy qwordy changed the title {Compute} Update help message - changed the term "Low Priority" to "Spot" {Compute} Update help message. Change the term "Low Priority" to "Spot" Jun 16, 2020
@yungezz
Copy link
Member

yungezz commented Jun 16, 2020

hi @qwordy could you pls help on the CI failure then we can merge this PR? thanks

@qwordy
Copy link
Member

qwordy commented Jun 17, 2020

This test fails, test_role_assignment_handle_conflicted_assignments.
Could you run "git pull upstream dev" and then push?

@mimckitt
Copy link
Contributor Author

Anything I need to do in order to get this merged?

@qwordy
Copy link
Member

qwordy commented Jul 3, 2020

Anything I need to do in order to get this merged?

After the CI checks pass. It's a simple change. Merge from dev branch and push your commit. Let's see if checks can pass.

@yungezz yungezz closed this Jul 3, 2020
@yungezz yungezz reopened this Jul 3, 2020
@yungezz yungezz changed the title {Compute} Update help message. Change the term "Low Priority" to "Spot" {Compute} Update help message Change the term "Low Priority" to "Spot" Jul 3, 2020
@yungezz yungezz merged commit 9acc3e6 into Azure:dev Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants