Skip to content

{Graph} Fix #12797: ad app permission grant: Add prerequisite to the help message #14144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 4 commits into from
Jul 6, 2020
Merged

{Graph} Fix #12797: ad app permission grant: Add prerequisite to the help message #14144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b3248c
ad app permission grant: Add prerequisite to the help message
jiasli Jun 30, 2020
3db7f33
Add .github/CODEOWNERS
jiasli Jun 30, 2020
57cc581
Update _help.py
jiasli Jun 30, 2020
ea9523c
Update _help.py
jiasli Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/src/azure-cli/azure/cli/command_modules/policyinsights/ @cheggert
/src/azure-cli/azure/cli/command_modules/profile/ @jiasli @arrownj
/src/azure-cli/azure/cli/command_modules/resource/ @Juliehzl @zhoxing-ms @qianwens
/src/azure-cli/azure/cli/command_modules/role/ @jiasli
/src/azure-cli/azure/cli/command_modules/role/ @jiasli @qianwens @arrownj
Copy link
Member Author

@jiasli jiasli Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yungezz, @yonzhan, Adding code owners @qianwens @arrownj.

/src/azure-cli/azure/cli/command_modules/storage/ @Juliehzl @qianwens
/src/azure-cli/azure/cli/command_modules/servicefabric/ @QingChenmsft @qwordy
/src/azure-cli/azure/cli/command_modules/sql/ @jaredmoo @Juliehzl
Expand Down
6 changes: 5 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,11 @@
helps['ad app permission grant'] = """
type: command
short-summary: Grant the app an API Delegated permissions
long-summary: for Application permissions, please use "ad app permission admin-consent"
long-summary: >
A service principal must exist for the app when running this command. To create a corresponding service
principal, use `az ad sp create --id {appId}`.

For Application permissions, please use "ad app permission admin-consent"
examples:
- name: Grant a native application with permissions to access an existing API with TTL of 2 years
text: az ad app permission grant --id e042ec79-34cd-498f-9d9f-1234234 --api a0322f79-57df-498f-9d9f-12678 --expires 2
Expand Down