[Webapp] Bugfix: az webapp log deployment show - return deployment logs instead of log metadata #14146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Webapp |
qwordy
reviewed
Jul 3, 2020
qwordy
approved these changes
Jul 3, 2020
calvinsID
force-pushed
the
issue-14099-fix-deployment-logs
branch
from
420ead2 to
96dbdde
Compare
Member
|
ready to merge? |
Contributor
Author
Ready, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #14099
Testing Guide
az webapp log deployment showShould have output of a list of logs similar to:
[
{
"log_time": "2020...",
"id": "id",
"message": "log message",
"type": 0,
"details_url": null
},
{
"log_time": "2020...",
"id": "id",
"message": "log message 2",
"type": 0,
"details_url": null
}
]
Rather than an object similar to
{
"active": false,
"author": "N/A",
"author_email": "N/A",
"complete": true,
"deployer": "GITHUB_ZIP_DEPLOY",
"end_time": "2020-06-25T19:04:18.8758562Z",
"id": "id",
"is_readonly": true,
"is_temp": false,
"last_success_end_time": "2020-06-25T19:04:18.8758562Z",
"log_url": "https://calvin-githubactions-webapp.scm.azurewebsites.net/api/deployments/deploymentId/log",
"message": "Created via a push deployment",
"progress": "",
"received_time": "2020-06-25T19:04:00.9811072Z",
"site_name": "calvin-githubactions-webapp",
"start_time": "2020-06-25T19:04:01.061354Z",
"status": 4,
"status_text": "",
"url": "https://calvin-githubactions-webapp.scm.azurewebsites.net/api/deployments/deploymentId"
}
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.