{Core} Fix #14175: Load ALWAYS_LOADED_EXTENSIONS correctly #14180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
mmyyrroonn and
qianwens
as code owners
jiasli
commented
Jul 3, 2020
Comment on lines
+396
to
+398
| if command_str in self.command_group_table: | ||
| logger.debug("Found a match in the command group table for '%s'", command_str) | ||
| return self.command_table |
Member
Author
There was a problem hiding this comment.
Separate the debug log for found in command table and found in the command group table.
|
|
||
| # Format string for pretty-print the command module table | ||
| header_mod = "%-20s %10s %9s %9s" % ("Extension", "Load Time", "Groups", "Commands") | ||
| header_mod = "%-20s %10s %9s %9s" % ("Name", "Load Time", "Groups", "Commands") |
jiasli
commented
Jul 3, 2020
| filtered_extensions.append(ext) | ||
| extension_modname.remove(ext_mod) | ||
| if extension_modname: | ||
| logger.debug("These extensions are not installed and will be skipped: %s", extension_modname) |
Member
Author
There was a problem hiding this comment.
Will show something like
These extensions are not installed and will be skipped: ['azext_ai_examples', 'azext_ai_did_you_mean_this']
Collaborator
|
add to S172 |
haroldrandom
approved these changes
Jul 6, 2020
This was referenced Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14175: ai-did-you-mean-this extension is not loaded after a first run
Currently, if no extension corresponds to a command like
az accountin Command Index:_update_command_table_from_extensionswon't be called, thus leftALWAYS_LOADED_EXTENSIONSignored.This PR fixes this issue by always calling
_update_command_table_from_modulesand_update_command_table_from_extensions.Testing Guide