{Packaging/RPM} Remove unused *.pyo and *.pyc in RPM #14288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungezz
reviewed
Jul 9, 2020
| exit_code = subprocess.call(['{} --junit-xml /azure_cli_test_result/{}.xml --pyargs azure.cli.command_modules.{}'.format(pytest_base_cmd, mod_name, mod_name)], shell=True) | ||
| else: | ||
| exit_code = subprocess.call(['{} --junit-xml /azure_cli_test_result/{}.xml --pyargs azure.cli.command_modules.{}'.format(pytest_parallel_cmd, mod_name, mod_name)], shell=True) | ||
| if exit_code != 0 and exit_code != 5: # exit code is 5 when there is no tests collected in the module |
Member
There was a problem hiding this comment.
when no tests found, it's better to at least stdout some message
Member
Author
There was a problem hiding this comment.
The extension module do not have tests. Extension tests are under azure-cli-core.
| pip3 install pytest --prefix /usr/lib64/az | ||
| pip3 install pytest-xdist --prefix /usr/lib64/az | ||
|
|
||
| find /azure-cli/artifacts/build -name "azure_cli_testsdk*" | xargs pip3 install --prefix /usr/lib64/az --upgrade --ignore-installed |
Member
There was a problem hiding this comment.
is it necessary to pin version also?
Member
Author
There was a problem hiding this comment.
azdev uses pytest>=4.4.0, which would always install the latest version in CI enviroment and achieves the same effect as no version specified.
Maybe we should first pin it in azdev to avoid breaking changes with pytest. @haroldrandom
fengzhou-msft
changed the title
haroldrandom
approved these changes
Jul 9, 2020
fengzhou-msft
commented
Jul 9, 2020
|
|
||
| %global __python %{__python3} | ||
| # Turn off python byte compilation | ||
| %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') |
Member
Author
There was a problem hiding this comment.
Based on the instruction from the Fedora Packaging Guideline.
Collaborator
|
Packaging/RPM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pycandpyofiles in the same location aspyfiles. Thepycfiles in__pycache__for Python 3 is still generated.MSI changes moved to #14300
Testing Guide
Checked in the code in the
build_testbranch, the packages built and results of the RPM test script can be found here.History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.