Skip to content

{Storage} Remove azure-storage-blob #14295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliehzl merged 7 commits into from
Jul 10, 2020
Merged

{Storage} Remove azure-storage-blob #14295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75f562b
remove
Juliehzl Jul 9, 2020
039faeb
remove
Juliehzl Jul 9, 2020
88e9329
add more infor
Juliehzl Jul 9, 2020
6c6c25c
add ex
Juliehzl Jul 9, 2020
5b6f7e3
raise
Juliehzl Jul 9, 2020
5efa052
add common
Juliehzl Jul 10, 2020
6de3f1d
add change for version
Juliehzl Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ci/test_extensions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ for ext in $output; do
fi
done

az self-test
az self-test --debug
if [ $? != 0 ]
then
exit_code=1
Expand Down
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/profile/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def check_cli(cmd):
except Exception as ex: # pylint: disable=broad-except
exceptions['load_commands'] = ex
logger.error('Error occurred loading commands!\n')
raise ex
Copy link
Member

@jiasli jiasli Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raise ex makes this function exit, thus exceptions is no longer checked and useless.


print('Retrieving all help...')
try:
Expand All @@ -223,6 +224,7 @@ def check_cli(cmd):
except Exception as ex: # pylint: disable=broad-except
exceptions['load_help'] = ex
logger.error('Error occurred loading help!\n')
raise ex

if not exceptions:
print('CLI self-test completed: OK')
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ azure-mgmt-web==0.47.0
azure-multiapi-storage==0.3.2
azure-nspkg==3.0.2
azure-loganalytics==0.1.0
azure-storage-blob==1.5.0
azure-storage-common==1.4.2
bcrypt==3.1.7
certifi==2019.6.16
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/requirements.py3.Linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ azure-mgmt-web==0.47.0
azure-multiapi-storage==0.3.2
azure-nspkg==3.0.2
azure-loganalytics==0.1.0
azure-storage-blob==1.5.0
azure-storage-common==1.4.2
bcrypt==3.1.7
certifi==2019.6.16
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/requirements.py3.windows.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ azure-mgmt-web==0.47.0
azure-multiapi-storage==0.3.2
azure-nspkg==3.0.2
azure-loganalytics==0.1.0
azure-storage-blob==1.5.0
azure-storage-common==1.4.2
bcrypt==3.1.7
certifi==2019.6.16
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
'azure-mgmt-web~=0.47.0',
'azure-multiapi-storage~=0.3.2',
'azure-loganalytics~=0.1.0',
'azure-storage-blob>=1.3.1,<2.0.0',
'azure-storage-common~=1.4',
'cryptography>=2.3.1,<3.0.0',
'fabric~=2.4',
'jsmin~=2.2.2',
Expand Down