Skip to content

[Extension] Support automatically installing an extension if the extension of a command is not installed #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzhou-msft merged 24 commits into from
Jul 31, 2020
Merged

[Extension] Support automatically installing an extension if the extension of a command is not installed #14478

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
83be3af
dynamic extension install poc
fengzhou-msft Jul 11, 2020
9b3fa62
fix cli_ctx
fengzhou-msft Jul 12, 2020
ef4f251
continue run with subprocess
fengzhou-msft Jul 14, 2020
3c552a7
add config
fengzhou-msft Jul 15, 2020
3f800bd
donwload remote index
fengzhou-msft Jul 16, 2020
e2b667b
check close matches first
fengzhou-msft Jul 17, 2020
1b6857f
change config name
fengzhou-msft Jul 17, 2020
3ee5415
add option to turn off dynamic install
fengzhou-msft Jul 17, 2020
32ccc49
Merge branch 'dev' into dynamic_extension_install
fengzhou-msft Jul 17, 2020
72b1506
add option to turn off dynamic install
fengzhou-msft Jul 17, 2020
bf8f7ee
fix when cli_ctx is None
fengzhou-msft Jul 17, 2020
1681fb4
resolve conflicts
fengzhou-msft Jul 20, 2020
4bd9965
add no prompt msg
fengzhou-msft Jul 21, 2020
28360a0
modify message
fengzhou-msft Jul 21, 2020
18efb12
default to no
fengzhou-msft Jul 23, 2020
de3fda3
refactor error msg
fengzhou-msft Jul 23, 2020
00cc9cb
fix style
fengzhou-msft Jul 23, 2020
1abde7c
resolve UX comments
fengzhou-msft Jul 27, 2020
447f63d
Merge branch 'dev' into dynamic_extension_install
fengzhou-msft Jul 29, 2020
93dd684
Merge branch 'dynamic_extension_install' of github.com:fengzhou-msft/…
fengzhou-msft Jul 30, 2020
e9530f5
make changes backward compatible
fengzhou-msft Jul 30, 2020
181c3ec
add test
fengzhou-msft Jul 30, 2020
2e68097
fix shell
fengzhou-msft Jul 30, 2020
4b16148
fix style
fengzhou-msft Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change config name
  • Loading branch information
@fengzhou-msft
fengzhou-msft committed Jul 17, 2020
commit 1b6857f850170d29f430ed2e6fa0560ce9429c20
4 changes: 2 additions & 2 deletions src/azure-cli-core/azure/cli/core/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def _check_value(self, action, value): # pylint: disable=too-many-statements
extension_name=ext_name) # TODO add extension_version
cli_ctx = self.cli_ctx or self.cli_help.cli_ctx
ask_before_dynamic_extension_install = cli_ctx.config.getboolean(
'extension', 'ask_before_dynamic_extension_install', True)
'extension', 'ask_before_dynamic_install', True)
if ask_before_dynamic_extension_install:
from knack.prompting import prompt_y_n
go_on = prompt_y_n(
Expand All @@ -344,7 +344,7 @@ def _check_value(self, action, value): # pylint: disable=too-many-statements
from azure.cli.core.extension.operations import add_extension
add_extension(cli_ctx=cli_ctx, extension_name=ext_name)
run_after_extension_installed = cli_ctx.config.getboolean('extension',
'run_after_extension_installed',
'run_after_dynamic_install',
True)
if run_after_extension_installed:
import subprocess
Expand Down