Skip to content

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Jul 29, 2020

Description

Fix issue #14323
Add data plane support for Query Acceleration feature (https://docs.microsoft.com/azure/storage/blobs/data-lake-storage-query-acceleration) into CLI.

Testing Guide

  • Prepare blob named quick_query.csv
    • Show result directly
      az storage blob query -c test -n quick_query.csv --query-expression "SELECT _2 FROM BlobStorage" --account-name zuhdefault --account-key xxxxxx
    • Save result in file
      az storage blob query -c test -n quick_query.csv --query-expression "SELECT _2 FROM BlobStorage" --account-name zuhdefault --account-key xxxxxx --result-file xxx.csv

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@Juliehzl Juliehzl added the Need SDK released Pending for sdk release label Jul 29, 2020
@yonzhan yonzhan added this to the S174 milestone Jul 29, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2020

Storage

@yonzhan yonzhan modified the milestones: S174, S175 - For Ignite Aug 22, 2020
@Juliehzl Juliehzl requested a review from zhoxing-ms as a code owner August 24, 2020 04:54
@Juliehzl Juliehzl added Storage az storage and removed Need SDK released Pending for sdk release labels Aug 24, 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select/project on blob/or blob snapshot This means "select project on blob or blob snapshot", right? What does / mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines 885 to 898
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line_separator = CLIArgumentType(help="The string used to separate records.", default='\n')
column_separator = CLIArgumentType(help="The string used to separate columns.", default=',')
quote_char = CLIArgumentType(help="The string used to quote a specific field.", default='"')
record_separator = CLIArgumentType(help="The string used to separate records.", default='\n')
escape_char = CLIArgumentType(help="The string used as an escape character. Default to empty.", default="")

Can these CLIArgumentTypes be reused here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this part

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl Juliehzl merged commit db6c587 into Azure:dev Sep 14, 2020
@Juliehzl Juliehzl deleted the track2-query branch September 14, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage az storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants