[SQL] az sql server audit-policy: Add sql server auditing support
#14726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omersavion
changed the title
Collaborator
|
Auditing |
Juliehzl
reviewed
Aug 12, 2020
This reverts commit d6b180d.
Juliehzl
reviewed
Aug 14, 2020
Contributor
|
Hi @omersavion, could you also get @jaredmoo approval? |
added new command group as preview
Juliehzl
changed the title
az sql server audit-policy: Add sql server auditing support
Contributor
|
@omersavion any update? |
Contributor
Author
|
Still waiting for @jaredmoo to approve this PR. |
Juliehzl
approved these changes
Aug 19, 2020
Collaborator
|
@jaredmoo there is only one day left for this PR to get merged. Please help review it ASAP. |
Contributor
|
Because we will stop build today and there is no response from Jaredmoo, I will help merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support sql server auditing in Azure CLI. Azure CLI currently supports sql database auditing (sql db audit-policy). This PR adds the support in server auditing too, using sql server audit-policy, which is similar to sql db audit-policy: https://docs.microsoft.com/en-us/cli/azure/sql/db/audit-policy?view=azure-cli-latest
In addition, updating the test of sql db audit-policy (test_sql_db_security_mgmt).
Testing Guide
Testing can be done manually by using the commands "az sql server audit-policy show" or "az sql server audit-policy update" with the same arguments as sql db audit-policy, when --name is the name of the server, and there is no --server argument.
Testing can also be done by running the sql module test ("%ROOT%\src\azure-cli\azure\cli\command_modules\sql\tests\latest\test_sql_commands.py", specifically the test "test_sql_server_security_mgmt".
Release Note
Added new commands
az sql server audit-policy showandaz sql server audit-policy updateto view and manage audit policy for sql server.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.