[SQL] upgrade azure-mgmt-sql to 0.20.0 #14728
Conversation
|
SQL |
|
Old PR #14515 abandoned due to branch issues. |
|
|
||
| self.kwargs.update({ | ||
| 'subnet_id': subnet['id'] | ||
| 'subnet_id': '/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/v-urmila/providers/Microsoft.Network/virtualNetworks/MIVirtualNetwork/subnets/ManagedInsanceSubnet' |
There was a problem hiding this comment.
Fixed resource is not recommend in azure cli because it is hard for others to re-run with such resources. May I know why you want to fix resources here?
|
Hi @toki95, from my investigation, the PR only upgrades package version but as you mentioned in PR title, it should also add new parameters in some existing commands. With the new package, new parameters will be added automatically or you still need additional work? |
|
@toki95 any update? |
Sorry I was OOF, I don't need any additional work. |
|
@Juliehzl can we merge this PR now? |
|
|
||
| self.kwargs.update({ | ||
| 'subnet_id': subnet['id'] | ||
| 'subnet_id': '/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/v-urmila/providers/Microsoft.Network/virtualNetworks/MIVirtualNetwork/subnets/ManagedInsanceSubnet' |
There was a problem hiding this comment.
fixed resource is not recommended in test.
There was a problem hiding this comment.
The main issue with this is that MI tests are not easily setup. They also run very long when fully setup (>4h). I agree that it should be fixed. My take is that I believe Jovana is not making tests non-recordable, since they usually are, and with or without her change, people would need to do some manual setup/preparing in order to record.
There was a problem hiding this comment.
discussed with Jovana and Perica offline. They have to make network resource fixed given policy set on their subscription.
is it possible to disable the policy before you run the test and enable it again after done?
There was a problem hiding this comment.
discussed with Jovana. They cannot disable policy.
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
I haven't find command parameter change in your description. Because PR title will be used as release note, please change the description for what you did in the PR.
From my perspective, what you do is just "upgrade azure-mgmt-sql to 0.20.0". IF it is not correct, feel free to use your words.
toki95
changed the title
Done |
7 participants
Description
Add az sql mi op list, az sql mi op get to display operation steps and operation parameters
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.