Skip to content

Conversation

@anusapan
Copy link
Contributor

Description
Removing the remaining legacy parts of the PnP as this is unused and the commands has already been moved to the extension.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 11, 2020

Iot Hub

@yonzhan yonzhan requested a review from qwordy August 11, 2020 02:28
@yonzhan yonzhan added this to the S174 milestone Aug 11, 2020
@zhoxing-ms
Copy link
Contributor

@anusapan May I ask will these deletions cause breaking changes to customers?

@anusapan
Copy link
Contributor Author

anusapan commented Aug 13, 2020

@anusapan May I ask will these deletions cause breaking changes to customers?

@zhoxing-ms No, these are the files which aren't in use anymore

@zhoxing-ms
Copy link
Contributor

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?

@anusapan
Copy link
Contributor Author

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?

@zhoxing-ms Adding SDK here, was a long time back, but now we are doing some data-plane operations, So we have planned to move this out to iot-extension. Everything already moved to the extension and this PR is for removing the remaining files which are no longer in use

@zhoxing-ms
Copy link
Contributor

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?

@zhoxing-ms Adding SDK here, was a long time back, but now we are doing some data-plane operations, So we have planned to move this out to iot-extension. Everything already moved to the extension and this PR is for removing the remaining files which are no longer in use

Got it~ Thanks

@Juliehzl
Copy link
Contributor

Because there is no code owner, nobody could merge the PR now @yonzhan

@zhoxing-ms
Copy link
Contributor

@digimaun Could you please help to review and merge this PR?

@zhoxing-ms zhoxing-ms merged commit 9004736 into Azure:dev Aug 21, 2020
@anusapan anusapan deleted the iot-pnp branch August 22, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants