-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Iot Hub} Removed remaining PnP parts #14733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Iot Hub |
|
@anusapan May I ask will these deletions cause breaking changes to customers? |
@zhoxing-ms No, these are the files which aren't in use anymore |
|
@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before? |
@zhoxing-ms Adding SDK here, was a long time back, but now we are doing some data-plane operations, So we have planned to move this out to iot-extension. Everything already moved to the extension and this PR is for removing the remaining files which are no longer in use |
Got it~ Thanks |
|
Because there is no code owner, nobody could merge the PR now @yonzhan |
|
@digimaun Could you please help to review and merge this PR? |
Description
Removing the remaining legacy parts of the PnP as this is unused and the commands has already been moved to the extension.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.