[IoT] Enabled minimum TLS version on IoT Hub Create #14882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digimaun
reviewed
Aug 21, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/latest/test_iot_commands.py
Show resolved
Hide resolved
Collaborator
|
IoT |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
@yonzhan / @zhoxing-ms - anything holding this back from being reviewed / merged? |
Collaborator
|
@zhoxing-ms please help with this PR. |
zhoxing-ms
reviewed
Sep 1, 2020
Co-authored-by: Xing Zhou <[email protected]>
Member
Author
|
@zhoxing-ms - after that string change, looks like CI failed due to timeout loading webapp module - can we re-run the CI please? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
digimaun
approved these changes
Sep 9, 2020
zhoxing-ms
approved these changes
Sep 10, 2020
Member
Author
|
@zhoxing-ms - anything specific holding this back from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables users to create IoT Hubs through the CLI with a minTLS version (currently only "1.2") set.
Testing Guide
To create a hub that enforces TLS version 1.2:
az iot hub create -n {hub_name} -g {resource_group} -l {location} --sku {sku} --min-tls-version 1.2History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.