Skip to content

Conversation

@MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented Aug 22, 2020

Description
This PR introduces the migration cmdlets for Autoscale feature. The migration cmdlets facilitate migration of autoscale throughput to manually provisioned throughput and vice-versa.

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@MehaKaushik MehaKaushik changed the title Autoscale migration [CosmosDB] Support for Migration APIs in Autoscale Aug 22, 2020
@MehaKaushik MehaKaushik force-pushed the autoscale_migration branch 2 times, most recently from 1fa7aac to ca7b1ee Compare August 22, 2020 23:10
@MehaKaushik MehaKaushik changed the title [CosmosDB] Support for Migration APIs in Autoscale [CosmosDB] Support for Migration APIs for Throughput resource Aug 22, 2020
@yonzhan yonzhan added this to the S175 - For Ignite milestone Aug 23, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 23, 2020

CosmosDB

@Juliehzl
Copy link
Contributor

@MehaKaushik please make sure CI pass for furthur review.

@MehaKaushik
Copy link
Contributor Author

@Juliehzl can you please help me with the CI, looks like after my last push, cosmosdb is not being recognized as a valid module.

@MehaKaushik
Copy link
Contributor Author

Ping @Juliehzl

@MehaKaushik
Copy link
Contributor Author

/azp run

@MehaKaushik
Copy link
Contributor Author

@zhoxing-ms can you please merge it

@zhoxing-ms
Copy link
Contributor

@zhoxing-ms can you please merge it

@Juliehzl Please help to have a look~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add some examples for new commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the examples manually, looks like the style and linter checks are failing after doing so. Is there a way to autogenerate these examples ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juliehzl I have reverted the change where I was adding examples, I will take this up in my next PR. Can you please merge this PR today, so that it makes into the upcoming release cycle. There are customers who are looking forward to this change.

@Juliehzl
Copy link
Contributor

please take a look at my comments

@MehaKaushik
Copy link
Contributor Author

@Juliehzl addressed the new comments.

Meha Kaushik added 3 commits September 14, 2020 15:33
@Juliehzl
Copy link
Contributor

@Juliehzl Zunli Hu FTE addressed the new comments.

also need to resolve all conflicts

1 similar comment
@Juliehzl
Copy link
Contributor

@Juliehzl Zunli Hu FTE addressed the new comments.

also need to resolve all conflicts

@Juliehzl Juliehzl merged commit 3e1841d into Azure:dev Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants