-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[CosmosDB] Support for Migration APIs for Throughput resource for Autoscale feature in CosmosDB #14887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1fa7aac to
ca7b1ee
Compare
|
CosmosDB |
|
@MehaKaushik please make sure CI pass for furthur review. |
|
@Juliehzl can you please help me with the CI, looks like after my last push, cosmosdb is not being recognized as a valid module. |
|
Ping @Juliehzl |
|
/azp run |
|
@zhoxing-ms can you please merge it |
@Juliehzl Please help to have a look~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add some examples for new commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the examples manually, looks like the style and linter checks are failing after doing so. Is there a way to autogenerate these examples ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Juliehzl I have reverted the change where I was adding examples, I will take this up in my next PR. Can you please merge this PR today, so that it makes into the upcoming release cycle. There are customers who are looking forward to this change.
|
please take a look at my comments |
Co-authored-by: Zunli Hu <[email protected]>
c3f14fe to
2109770
Compare
|
@Juliehzl addressed the new comments. |
also need to resolve all conflicts |
1 similar comment
also need to resolve all conflicts |
Description
This PR introduces the migration cmdlets for Autoscale feature. The migration cmdlets facilitate migration of autoscale throughput to manually provisioned throughput and vice-versa.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.