Skip to content

{CI} Example of bypassing show-command linter rule #14903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 3 commits into from
Aug 25, 2020
Merged

{CI} Example of bypassing show-command linter rule #14903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
438c038
bump to azdev 0.1.28
Aug 25, 2020
5f07732
disable four show-command linter rules
Aug 25, 2020
888974a
ignore bad-option-value for normal pylint
Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/azdev_setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ steps:
chmod +x env/bin/activate
. env/bin/activate

pip install -q azdev==0.1.26
pip install -q azdev==0.1.28
azdev --version

if [ -z "$CLI_EXT_REPO_PATH" ]; then
Expand Down
3 changes: 2 additions & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ disable=
cyclic-import,
too-many-arguments,
invalid-name,
duplicate-code
duplicate-code,
bad-option-value

[FORMAT]
max-line-length=120
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def load_command_table(self, _):
g.custom_command('delete', 'delete_host_key')

with self.command_group('functionapp function') as g:
g.custom_command('show', 'show_function')
g.custom_command('show', 'show_function') # pylint: disable=show-command
g.custom_command('delete', 'delete_function')

with self.command_group('functionapp function keys') as g:
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/configure/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ def load_command_table(self, _):

with self.command_group('cache', configure_custom, is_preview=True) as g:
g.command('list', 'list_cache_contents')
g.command('show', 'show_cache_contents')
g.command('show', 'show_cache_contents') # pylint: disable=show-command
g.command('delete', 'delete_cache_contents')
g.command('purge', 'purge_cache_contents')

with self.command_group('local-context', configure_custom, is_experimental=True) as g:
g.command('on', 'turn_local_context_on')
g.command('off', 'turn_local_context_off')
g.command('show', 'show_local_context', validator=validate_local_context)
g.command('show', 'show_local_context', validator=validate_local_context) # pylint: disable=show-command
g.command('delete', 'delete_local_context', validator=validate_local_context_for_delete)
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/hdinsight/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def load_command_table(self, _): # pylint: disable=too-many-statements
with self.command_group('hdinsight autoscale', hdinsight_clusters_sdk, client_factory=cf_hdinsight_clusters) as g:
g.custom_command('create', 'create_autoscale', supports_no_wait=True)
g.custom_command('update', 'update_autoscale', supports_no_wait=True)
g.custom_command('show', 'show_autoscale')
g.custom_show_command('show', 'show_autoscale')
g.custom_command('delete', 'delete_autoscale', supports_no_wait=True, confirmation=True)
g.custom_command('list-timezones', 'list_timezones')
g.wait_command('wait')
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/vm/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ def load_command_table(self, _):
g.command('delete', 'delete')

with self.command_group('vm monitor log', client_factory=cf_log_analytics_data_plane) as g:
g.custom_command('show', 'execute_query_for_vm', transform=transform_log_analytics_query_output)
g.custom_command('show', 'execute_query_for_vm', transform=transform_log_analytics_query_output) # pylint: disable=show-command

with self.command_group('vm monitor metrics', custom_command_type=monitor_custom, command_type=metric_definitions_sdk, resource_type=ResourceType.MGMT_MONITOR, operation_group='metric_definitions', min_api='2018-01-01', is_preview=True) as g:
from azure.cli.command_modules.monitor.transformers import metrics_table, metrics_definitions_table
Expand Down