[App Service] Fix #12653: az webapp log config --application-logging false doesn't turn it off #14929
Conversation
| <OutputPath>.</OutputPath> | ||
| <ProjectTypeGuids>{888888a0-9f3d-457c-b088-3a5042f75d52}</ProjectTypeGuids> | ||
| <LaunchProvider>Standard Python launcher</LaunchProvider> | ||
| <InterpreterId>MSBuild|env|$(MSBuildProjectFullPath)</InterpreterId> |
There was a problem hiding this comment.
remove this file from PR
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
mostly looks good please update a few - also please update or add test case for toggling application-logging if not already done. Thanks!
| ]) | ||
|
|
||
| @ResourceGroupPreparer(parameter_name_for_location='location', location=WINDOWS_ASP_LOCATION_WEBAPP) | ||
| @ResourceGroupPreparer(random_name_length=17, parameter_name_for_location='location', location=WINDOWS_ASP_LOCATION_WEBAPP) |
There was a problem hiding this comment.
Please add a comment here this is temporary until the bug fix in the API is deployed successfully & should be removed.
There was a problem hiding this comment.
Why random_name_length=17 can fix it?
There was a problem hiding this comment.
This is because we had a regression in our API with the length of the RG - @ThejaChoudary I believe the fix for this is already deployed -so we can remove this hack on the test and re-try.
|
App Service |
|
@ThejaChoudary please rebase to latest dev so we get a new build as well. Otherwise LGTM! |
5 participants
Description
Fixes #12653
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.