Skip to content

Conversation

@qwordy
Copy link
Member

@qwordy qwordy commented Sep 10, 2020

Description

  • Support upgrading API version in pipeline.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

jiasli
jiasli previously requested changes Sep 10, 2020
Copy link
Member

@jiasli jiasli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why is the title CAPITALIZED?
  2. It's better to compress the history.
  3. Please add some description.

# Commit changes
if [[ "$(USER_USERNAME)" != "" || "$(USER_TOKEN)" != "" ]]; then
azdev test $(Target) --no-exitfirst -a "-n $(USER_PARALLELISM)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Target not capitalized like USER_USERNAME?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one is internal, one is user variable.

# Commit changes
if [[ "$(USER_USERNAME)" != "" || "$(USER_TOKEN)" != "" ]]; then
REPO="$(USER_REPO)"
git clone -b $(USER_BRANCH) ${REPO:0:8}$(USER_USERNAME):$(USER_TOKEN)@${REPO:8}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments about this magical line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if one of USER_USERNAME and USER_TOKEN is empty?

@yonzhan yonzhan requested review from Juliehzl and jsntcy September 10, 2020 16:12
@jiasli jiasli dismissed their stale review September 11, 2020 02:33

Cancel.

@qwordy qwordy changed the title {TEST} LIVE TEST PIPELINE {Test} Live test pipeline Sep 11, 2020
@yungezz
Copy link
Member

yungezz commented Sep 14, 2020

hi @qwordy how about merge the pipeline, the PR contains huge commit history. We can continue update after first merging.

# Commit changes
if [[ "$(USER_USERNAME)" != "" || "$(USER_TOKEN)" != "" ]]; then
azdev test $(Target) --no-exitfirst -a "-n $(USER_PARALLELISM)"
azdev test $(Target) --live --lf --xml-path test_results.parallel.xml --no-exitfirst -a "-n $(USER_PARALLELISM) --json-report --json-report-summary --json-report-file=$(Target).report.parallel.json --html=$(Target).report.parallel.html --self-contained-html --reruns 3 -s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to point out that some ADO agent only has 2 cores and the current default USER_PARALLELISM=8 will not be run as expected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 cores does not mean it can only run 2 processes.
https://en.wikipedia.org/wiki/Context_switch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs in pipeline

RUNNING TESTS LIVE
The tests are set to run against current profile "latest"
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1 -- /home/vsts/work/1/env/bin/python
[gw0] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw1] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw2] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw3] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw4] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw5] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw6] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw7] linux Python 3.8.5 cwd: /home/vsts/work/1

[gw0] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw1] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw2] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw3] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw4] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw5] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw6] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]

[gw7] Python 3.8.5 (default, Jul 21 2020, 12:22:34)  -- [GCC 7.5.0]
gw0 [216] / gw1 [216] / gw2 [216] / gw3 [216] / gw4 [216] / gw5 [216] / gw6 [216] / gw7 [216]

cd azure-cli
git status
git add .
git commit -m "auto commit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is for updating recording files? The commit message could be more concrete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good idea.

@qwordy
Copy link
Member Author

qwordy commented Sep 14, 2020

hi @qwordy how about merge the pipeline, the PR contains huge commit history. We can continue update after first merging.

Yes. Very huge. I think I need to delete the branch and checkout a new branch from dev with same name. Then it is very clean.

@qwordy qwordy merged commit 9d9f7c0 into Azure:dev Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants