Skip to content

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Sep 10, 2020

Description

Fix issue #15025

With azure.core, all get_token method will need two addition arguments: *scope and **kwargs.
Here is a fix for msi login.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@Juliehzl Juliehzl changed the title [Storage] az storage blob list: Fix issue 15051 for msi login issue [Core] Fix issue 15051 for msi login issue in azure.core Sep 10, 2020
@jiasli
Copy link
Member

jiasli commented Sep 10, 2020

  1. Please follow the PR title convention and describe what the "issue" is:

    [Core] Fix Dependency on non-existing version 0.4.1 of azure-multiapi-storage #15051: MSIAuthenticationWrapper not working with azure.core

  2. I can't seem to see the relationship with Dependency on non-existing version 0.4.1 of azure-multiapi-storage #15051

@yonzhan yonzhan requested a review from zhoxing-ms September 10, 2020 16:09
@yonzhan yonzhan added this to the S175 - For Ignite milestone Sep 10, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 10, 2020

Core

@Juliehzl Juliehzl merged commit c2b9a2c into Azure:dev Sep 14, 2020
@Juliehzl Juliehzl deleted the fix15051 branch September 14, 2020 01:40
@Juliehzl Juliehzl changed the title [Core] Fix issue 15051 for msi login issue in azure.core [Core] Fix #15025: MSIAuthenticationWrapper not working with azure.core Sep 14, 2020
@Juliehzl
Copy link
Contributor Author

  1. Please follow the PR title convention and describe what the "issue" is:

    [Core] Fix Dependency on non-existing version 0.4.1 of azure-multiapi-storage #15051: MSIAuthenticationWrapper not working with azure.core

  2. I can't seem to see the relationship with Dependency on non-existing version 0.4.1 of azure-multiapi-storage #15051

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants