[Compute] vm boot-diagnostics enable: --storage becomes optional; New command: vm boot-diagnostics get-boot-log-uris #15145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwordy
changed the title
yungezz
reviewed
Sep 14, 2020
| crafted: true | ||
| """ | ||
|
|
||
| helps['vm boot-diagnostics get-sas'] = """ |
Member
There was a problem hiding this comment.
sas is shared access signature, while the request is asking to get boot log url. Suggest to rename to get-log
Member
Author
There was a problem hiding this comment.
A sample response:
{
"consoleScreenshotBlobUri": "https://md-visib0spjzkmsn3z.blob.core.windows.net:443/3289a9bc-c41f-4750-9595-a6a41500fc30/vm1.66212157-7e08-48e9-bb0b-1b31fad6ea79.screenshot.bmp?sv=2017-04-17&sr=b&sig=z5YDfqrK93Lhd8QzWzTeRquDFVLalKmbkt5nZWppIk8%3d&se=2020-09-14T08%3a03%3a52Z&sp=r",
"serialConsoleLogBlobUri": "https://md-visib0spjzkmsn3z.blob.core.windows.net:443/3289a9bc-c41f-4750-9595-a6a41500fc30/vm1.66212157-7e08-48e9-bb0b-1b31fad6ea79.serialconsole.log?sv=2017-04-17&sr=b&sig=aaQNEtL2D%2bBgT1VtLjFkMx%2buaNRrMxM3CrTcXxwyvUs%3d&se=2020-09-14T08%3a03%3a52Z&sp=r"
}
It also contains screenshot.
how about get-uri or get-blob-uri?
Member
There was a problem hiding this comment.
thanks @qwordy . As we synced offline, with new managed storage for boot diagnostic log, 2 changes need.
- MUST change existing get_boot_log command to support showing content from managed storage uri, when log is managed storage, get uri from the new InstanceView API
- Nice to have add a new command
get_boot_log_uristo show boot log uris. This new command need to cover both scenarios also: managed storage, and user specified storage.
bim-msft
suggested changes
Sep 14, 2020
Co-authored-by: Bin Ma <[email protected]>
bim-msft
approved these changes
Sep 14, 2020
haroldrandom
approved these changes
Sep 14, 2020
fengzhou-msft
approved these changes
Sep 14, 2020
qwordy
changed the title
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #14539
[Compute] vm boot-diagnostics enable: --storage becomes optional
[Compute] New command: vm boot-diagnostics get-sas
How to try it: https://github.com/Azure/azure-cli/blob/dev/doc/try_new_features_before_release.md
Testing Guide
History Notes
[Compute] vm boot-diagnostics enable: --storage becomes optional
[Compute] New command: vm boot-diagnostics get-boot-log-uris
[Compute] vm boot-diagnostics get-boot-log: support managed storage
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.