[Storage] az storage fs access: Support managing ACLs recursively
#15221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juliehzl
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
jiasli,
jsntcy,
mmyyrroonn and
zhoxing-ms
as code owners
Collaborator
|
add to S176 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Juliehzl
force-pushed
the
recursive-acl
branch
from
fe8b4c1 to
d2fc93a
Compare
Juliehzl
force-pushed
the
recursive-acl
branch
from
33e3411 to
330816f
Compare
evelyn-ys
approved these changes
Oct 22, 2020
zhoxing-ms
reviewed
Oct 22, 2020
Comment on lines
+1691
to
+1692
| - name: Set the Access Control on a path and sub-paths in Azure Data Lake Storage Gen2 account. | ||
| text: az storage fs access set-recursive --acl "default:user:21cd756e-e290-4a26-9547-93e8cc1a8923:rwx" -p dir -f myfilesystem --account-name myadlsaccount --account-key 0000-0000 |
Contributor
There was a problem hiding this comment.
The format of the --acl parameter is [scope:][type]:[id]:[permissions], but the location of each part in the acl parameter seems to be a bit confusing. Could we describe it in more detail?
For example:
When permissions are not passed in for acl parameter in the first example, the input value is --acl "default:user:21cd756e-e290-4a26-9547-93e8cc1a8923", but when there are only type and permissions for acl parameter, the input value is --acl "user::r-x"
Contributor
Author
There was a problem hiding this comment.
Actually it is from SDK and it is hard to see more here. But we could provide a link about acl here.
zhoxing-ms
reviewed
Oct 22, 2020
...azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_adls_gen2_scenarios.py
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set/Update/Remove ACL reclusively on datalake gen2 items with a small amount of requests, for performance improvement. Since currently, set ACL one by one is too slow.
Wait for #15572 merge
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.