{Test} Fix some live tests for acr, appservice, backup, netappfiles, batch #15245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
qwordy and
yungezz
as code owners
Collaborator
|
Test |
fengzhou-msft
force-pushed
the
fix_live_tests_3
branch
from
b172228 to
4bdd85c
Compare
fengzhou-msft
force-pushed
the
fix_live_tests_3
branch
from
4bdd85c to
2242a96
Compare
fengzhou-msft
changed the title
fengzhou-msft
commented
Sep 24, 2020
Comment on lines
-55
to
53
|
|
||
| # Since this test requires core quota, we must statically create an account with quota | ||
| @ResourceGroupPreparer() | ||
| @BatchAccountPreparer() | ||
| def test_batch_pool_cmd( |
Member
Author
There was a problem hiding this comment.
Change to use resource preparers and you can use environment variables AZURE_CLI_TEST_DEV_RESOURCE_GROUP_NAME and AZURE_CLI_TEST_DEV_BATCH_ACCT_NAME for existing resources in live tests when necessary.
Member
Author
|
@bgklein can you help review the changes for batch tests? This is to fix the failures in our weekly live tests validation. The result from last week for batch is here: https://clitestresultstac.blob.core.windows.net/20200918224751live/batch.report.parallel.html |
Juliehzl
approved these changes
Sep 24, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
Approve for my code owner part
yungezz
approved these changes
Sep 25, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Juliehzl
pushed a commit
to Juliehzl/azure-cli
that referenced
this pull request
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
az acr identity assignandaz acr identity removeas operations on identity are async.VaultPreparerto disable soft delete and allow the vault delete to fail in soft-delete-enabled cases.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.