[AKS] Expect kube-dashboard addon be disabled by default #15267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arrownj
approved these changes
Sep 24, 2020
Contributor
arrownj
left a comment
arrownj
left a comment
There was a problem hiding this comment.
Hi @kaiqizhang , the code is good to me, could you please fix the CI error ?
Contributor
Author
|
@arrownj Done. |
Juliehzl
pushed a commit
to Juliehzl/azure-cli
that referenced
this pull request
Sep 30, 2020
Co-authored-by: Kaiqi Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now all clusters <= 1.18 have kube-dashboard addon profile. If one cluster don't have the profile, it means the cluster is 1.19 and should expect the addon be disabled.
Starting from 1.19, enabling kube-dashboard addon is not allowed, so added the error message.
Testing Guide
az aks browse -n test-cluster -g test-rg
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.