Skip to content

{Network} private-link-resource list: Update argument help message to make more clear #15304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 1 commit into from
Oct 9, 2020
Merged

{Network} private-link-resource list: Update argument help message to make more clear #15304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/azure-cli/azure/cli/command_modules/network/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ def load_arguments(self, _):
c.argument('rule_group_name',
options_list='--group-name',
help='The name of the web application firewall rule set group.')
c.argument('rules', nargs='+', help='List of rules that will be disabled.')
c.argument('rules', nargs='+', help='List of rules that will be disabled. If provided, --group-name must be provided too')

with self.argument_context('network application-gateway waf-policy managed-rule exclusion',
min_api='2019-09-01') as c:
Expand Down Expand Up @@ -1902,9 +1902,9 @@ def load_arguments(self, _):
register_providers()
for scope in ['private-link-resource', 'private-endpoint-connection']:
with self.argument_context('network {} list'.format(scope)) as c:
c.argument('name', required=False, help='Name of the resource', options_list=['--name', '-n'])
c.argument('resource_provider', required=False, help='Type of the resource.', options_list='--type', arg_type=get_enum_type(TYPE_CLIENT_MAPPING.keys()))
c.argument('resource_group_name', required=False)
c.argument('name', required=False, help='Name of the resource. If provided, --type and --resource-group must be provided too', options_list=['--name', '-n'])
c.argument('resource_provider', required=False, help='Type of the resource. If provided, --name and --resource-group must be provided too', options_list='--type', arg_type=get_enum_type(TYPE_CLIENT_MAPPING.keys()))
c.argument('resource_group_name', required=False, help='Name of resource group. If provided, --name and --type must be provided too')
c.extra('id', help='ID of the resource', validator=process_private_link_resource_id_argument)
for scope in ['show', 'approve', 'reject', 'delete']:
with self.argument_context('network private-endpoint-connection {}'.format(scope)) as c:
Expand Down