{Test} Pipeline update #15307
Merged
{Test} Pipeline update #15307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… representation of a pipeline run.
yungezz
reviewed
Sep 25, 2020
|
|
||
|
|
||
| def render(data, container_url, testdata, USER_REPO, USER_BRANCH, COMMIT_ID, USER_LIVE): | ||
| content = """ |
Member
There was a problem hiding this comment.
how about extract it to a seperate file?
Member
Author
There was a problem hiding this comment.
144 lines. Short file. Don't worry.
Member
Author
There was a problem hiding this comment.
https://jinja.palletsprojects.com/en/2.11.x/ is a good choice. But it costs more time to write code. The current content is simple. If it gets complex enough, we can use template engine.
fengzhou-msft
approved these changes
Sep 25, 2020
Juliehzl
pushed a commit
to Juliehzl/azure-cli
that referenced
this pull request
Sep 30, 2020
* fix a pipe bug * fix a db bug * history * log * history * Update pipeline run title * Generate index.html of HTML files of testing results. Design a unique representation of a pipeline run. * Make storage account container public * style * fix a minor bug * upload index.html * pip install requests * index.html * index.html * index.html * resolve comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.