-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[HDInsight] Add parameter --idbroker to support customer to create ESP cluster with HDInsight Id Broker
#15309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
HDInsight |
| 'creating cluster with Enterprise Security Package will not not allowed.') | ||
| c.argument('idbroker', arg_group='Cluster', action='store_true', | ||
| help='Specify to create ESP cluster with HDInsight ID Broker. If omitted, ' | ||
| 'creating ESP cluster with HDInsight ID broker will not not allowed.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b [](start = 64, length = 1)
nit: B capital
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b [](start = 64, length = 1)
nit: B capital
Thanks for your comment. Fixed
|
For this feature I can't add test because this feature requires some specific complicated condition. I have tested offline many times. |
Prefer adding tests if possible. Although I trust you have tested in your machine, I will have concern on incoming SDK upgrade, etc. |
It is hard for me to add test. because this is related with ESP it requires some specific identity that I can't hard code and I can't create dynamically. |
…ESP cluster with HDInsight Id Broker (Azure#15309) * {Docs} Remove stale reference in README to closed issue about extensions (Azure#12771) * Add parameter --idbroker to support esp with HIB * change broker to Broker in parameter help. Co-authored-by: Daniel Miller <[email protected]> Co-authored-by: Azure CLI Team <[email protected]> Co-authored-by: Zhenyu Zhou <[email protected]>
Description
Add parameter
--idbrokerto support customer to create ESP cluster with HDInsight Id BrokerTesting Guide
History Notes
[HDInsight] az hdinsight create: add deprecate information for argument
--public-networrk-access-typeand--outbound-public-network-access-type[HDInsight] az hdinsight create: add parameter
--idbrokerto support customer to create ESP cluster with HDInsight Id BrokerThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.