Skip to content

Conversation

@aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Sep 25, 2020

Description

Add parameter --idbroker to support customer to create ESP cluster with HDInsight Id Broker

Testing Guide

History Notes

[HDInsight] az hdinsight create: add deprecate information for argument --public-networrk-access-type and --outbound-public-network-access-type
[HDInsight] az hdinsight create: add parameter --idbroker to support customer to create ESP cluster with HDInsight Id Broker


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 25, 2020

HDInsight

'creating cluster with Enterprise Security Package will not not allowed.')
c.argument('idbroker', arg_group='Cluster', action='store_true',
help='Specify to create ESP cluster with HDInsight ID Broker. If omitted, '
'creating ESP cluster with HDInsight ID broker will not not allowed.')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b [](start = 64, length = 1)

nit: B capital

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b [](start = 64, length = 1)

nit: B capital

Thanks for your comment. Fixed

@aim-for-better
Copy link
Member Author

For this feature I can't add test because this feature requires some specific complicated condition. I have tested offline many times.

@Juliehzl
Copy link
Contributor

For this feature I can't add test because this feature requires some specific complicated condition. I have tested offline many times.

Prefer adding tests if possible. Although I trust you have tested in your machine, I will have concern on incoming SDK upgrade, etc.

@Juliehzl Juliehzl requested a review from deshriva September 28, 2020 10:30
@aim-for-better
Copy link
Member Author

For this feature I can't add test because this feature requires some specific complicated condition. I have tested offline many times.

Prefer adding tests if possible. Although I trust you have tested in your machine, I will have concern on incoming SDK upgrade, etc.

It is hard for me to add test. because this is related with ESP it requires some specific identity that I can't hard code and I can't create dynamically.

@Juliehzl Juliehzl merged commit 9ee8122 into Azure:dev Sep 28, 2020
Juliehzl pushed a commit to Juliehzl/azure-cli that referenced this pull request Sep 30, 2020
…ESP cluster with HDInsight Id Broker (Azure#15309)

* {Docs} Remove stale reference in README to closed issue about extensions (Azure#12771)

* Add parameter --idbroker to support esp with HIB

* change broker to Broker in parameter help.

Co-authored-by: Daniel Miller <[email protected]>
Co-authored-by: Azure CLI Team <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants