[AKS] Support add Spot node pool #15311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtxistxgao
changed the title
arrownj
reviewed
Sep 27, 2020
Member
|
hi @gtxistxgao which release you'd like this one to be in? From comments, this is GA item, seems has specific timeline |
Contributor
|
Hi @gtxistxgao , this is just a reminder that the CC date for next release is 9/30. Does this PR need to catch this release ? |
Contributor
Author
It's not that urgent as RP's change not ready yet. Sorry for the confusion. |
Contributor
Author
|
@arrownj the RP change is in. Please merge this one so we can catch up next release. |
Contributor
Author
yungezz
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support add Spot node pool as part of GA work item.
https://docs.microsoft.com/en-us/azure/aks/spot-node-pool
Testing Guide
az ask nodepool add -g resourceGroup --cluster-name clusterName -n spotPoolName --priority Spot --spot-max-price 88.88888
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.