[SIGNALR] az signalr create/update: Add new option --enable-messaging-logs
#15327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
SIGNALR |
zackliu
reviewed
Sep 29, 2020
zackliu
reviewed
Sep 29, 2020
|
|
||
| def signalr_create(client, signalr_name, resource_group_name, | ||
| sku, unit_count=1, location=None, tags=None, service_mode='Default', allowed_origins=None, default_action="Allow"): | ||
| sku, unit_count=1, location=None, tags=None, service_mode='Default', enable_message_logs='False', allowed_origins=None, default_action="Allow"): |
Member
There was a problem hiding this comment.
When using get_three_state_flag, the parameter should be a bool instead of string. Then, user can still use the lowercase true/false in commend line
Juliehzl
reviewed
Sep 30, 2020
|
|
||
| def signalr_create(client, signalr_name, resource_group_name, | ||
| sku, unit_count=1, location=None, tags=None, service_mode='Default', allowed_origins=None, default_action="Allow"): | ||
| sku, unit_count=1, location=None, tags=None, service_mode='Default', enable_message_logs='False', allowed_origins=None, default_action="Allow"): |
Contributor
There was a problem hiding this comment.
please make enable_messahe_logs=False, not 'False'
Juliehzl
reviewed
Sep 30, 2020
| tags_key = 'key' | ||
| tags_val = 'value' | ||
| service_mode = 'Classic' | ||
| enable_message_logs = 'True' |
Juliehzl
reviewed
Sep 30, 2020
|
|
||
| # Test update | ||
| self.cmd('az signalr update -n {signalr_name} -g {rg} --sku {updated_sku} --tags {updated_tags} --service-mode {update_service_mode}', | ||
| self.cmd('az signalr update -n {signalr_name} -g {rg} --sku {updated_sku} --tags {updated_tags} --service-mode {update_service_mode} --enable-message-logs {update_enable_message_logs}', |
Contributor
There was a problem hiding this comment.
please add test for --enable-message-logs false in not string variable.
Check value with boolean False, not string if the output type is boolean for features[1].value
Contributor
Author
There was a problem hiding this comment.
@Juliehzl Test added for --enable-message-logs false.
The check value is string since the SignalrFeature.value is a string.
haroldrandom
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new option
--enable-messaging-logsfor signalr, which can setup theEnableMessagingLogsinFeatureFlags. It's used to control whether the signalr service generate messaging logs or not.Testing Guide
Use
az signalr update -n <SIGNALR_NAME> -g <RESOURCE_GROUP> --enable-messaging-logs Trueto make signalr service start to generate messaing log for signalr instance SIGNALR_NAME in resource group RESOURCE_GROUP.Use
azdev test signalrto test includingaz signalr createandaz signalr updateHistory Notes
[SIGNALR] az signalr create: Add new option
--enable-messaging-logsfor controling service generate messaging logs or not[SIGNALR] az signalr update: Add new option
--enable-messaging-logsfor controling service generate messaging logs or notThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.