[AppService] BREAKING CHANGE: az webapp create, az webapp up - Update available webapp runtimes #15356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwordy
approved these changes
Sep 30, 2020
Contributor
|
@btardif if you can quickly review the new runtimes listed here. Thanks! |
Member
|
I am wondering can we have a public place to list supported runtimes. Then CLI code doesn't need to change. And all Azure clients can use one shared list instead of multiple local copies. |
Contributor
Author
|
@qwordy we are planning to use an API endpoint that will provide us the supported runtimes, however that PR is in progress and should be out S177. I made this PR to continue hardcoding these runtimes in order to make the S176 code complete deadline |
calvinsID
force-pushed
the
issue-15269-update-stacks
branch
from
3f9b199 to
815bd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15269
Updates runtimes to match the runtimes listed in Portal when creating webapp (aka.ms/canary).
When creating a webapp, only the updated list of runtimes can be used
Affects following commands:
az webapp up: can only create webapps using the updated list of runtimesaz webapp create: can only create webapps using the updated list of runtimesaz webapp list-runtimes: displays the updated list of runtimesWindows added:
Windows removed:
Linux added:
Linux removed:
Testing Guide
Run
az webapp list-runtimesandaz webapp list-runtimes --linux. The results should be the same as the list of runtimes available to choose from when creating a webapp on canary version of Portal (aka.ms/canary).Creating webapps using the commands
az webapp upandaz webapp createshould only be able to create webapps from the updated list of runtimesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.