Skip to content

Conversation

@petrajkogit
Copy link
Contributor

@petrajkogit petrajkogit commented Sep 30, 2020

Description
Fix response for backup storage redundancy param name and value for MI.

Since there is a difference in parameter name that is used by API (storageAccountType), and parameter name we are using to specify backup storage redundancy (backupStorageRedundancy), and the values we externally show (Geo, Local Zone) with this PR we are using transformation of output object, in order to show the expected parameter name and values for it, for better customer experience.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@petrajkogit petrajkogit changed the title Fix response for backup storage redundancy param name and value for MI [SQL] Fix response for backup storage redundancy param name and value for MI Sep 30, 2020
@yonzhan yonzhan added this to the S177 milestone Sep 30, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 30, 2020

SQL

@petrajkogit
Copy link
Contributor Author

@Juliehzl Hi Zunli, can you take a look at this PR? It is small change, and is open for some time. Thanks!

@Juliehzl
Copy link
Contributor

Juliehzl commented Oct 14, 2020

Hi @petrajkogit , your changes are minor but I have concern for changing output because there are too many usages for sql mi command and your change will cause breaking change for automation task.

There are at lease 403 unique subscriptions for sql mi in the past 30 days.

@petrajkogit
Copy link
Contributor Author

Hi @petrajkogit , your changes are minor but I have concern for changing output because there are too many usages for sql mi command and your change will cause breaking change for automation task.

There are at lease 403 unique subscriptions for sql mi in the past 30 days.

@Juliehzl Yes, however, this parameter is relatively new in response (from last release at end of September: https://github.com/Azure/azure-cli/releases/tag/azure-cli-2.12.0), so impact will not be that big. What is the alternative here, we would like to just show the correct name for output parameter (since the name from api response can be misleading)

@Juliehzl
Copy link
Contributor

Hi @petrajkogit , thanks for your information. Checked the telemetry again, there are 6 subscriptions usage in the past 90 days.
If you are fine with such change for your module, I am fine with it but you need to make it as breaking change in title.

@petrajkogit petrajkogit changed the title [SQL] Fix response for backup storage redundancy param name and value for MI [SQL] BREAKING CHANGE: Fix response for backup storage redundancy param name and value for MI Oct 16, 2020
@petrajkogit
Copy link
Contributor Author

petrajkogit commented Oct 16, 2020

Hi @petrajkogit , thanks for your information. Checked the telemetry again, there are 6 subscriptions usage in the past 90 days.
If you are fine with such change for your module, I am fine with it but you need to make it as breaking change in title.

@Juliehzl Yes we are fine. SQL DB already went with this change and we need to match the experience between SQL DB and SQL MI. I added the Breaking change tag to the PR title.

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for service team request

@Juliehzl Juliehzl merged commit 13bf794 into Azure:dev Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants