-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[SQL] BREAKING CHANGE: Fix response for backup storage redundancy param name and value for MI #15367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] BREAKING CHANGE: Fix response for backup storage redundancy param name and value for MI #15367
Conversation
Syncing with latest
Syncing
|
SQL |
|
@Juliehzl Hi Zunli, can you take a look at this PR? It is small change, and is open for some time. Thanks! |
|
Hi @petrajkogit , your changes are minor but I have concern for changing output because there are too many usages for There are at lease 403 unique subscriptions for |
@Juliehzl Yes, however, this parameter is relatively new in response (from last release at end of September: https://github.com/Azure/azure-cli/releases/tag/azure-cli-2.12.0), so impact will not be that big. What is the alternative here, we would like to just show the correct name for output parameter (since the name from api response can be misleading) |
|
Hi @petrajkogit , thanks for your information. Checked the telemetry again, there are 6 subscriptions usage in the past 90 days. |
@Juliehzl Yes we are fine. SQL DB already went with this change and we need to match the experience between SQL DB and SQL MI. I added the Breaking change tag to the PR title. |
Juliehzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for service team request
Description
Fix response for backup storage redundancy param name and value for MI.
Since there is a difference in parameter name that is used by API (storageAccountType), and parameter name we are using to specify backup storage redundancy (backupStorageRedundancy), and the values we externally show (Geo, Local Zone) with this PR we are using transformation of output object, in order to show the expected parameter name and values for it, for better customer experience.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.