Skip to content

Conversation

@tilnl
Copy link
Contributor

@tilnl tilnl commented Oct 8, 2020

Description

Add PPG support as part of GA work item

Testing Guide

az aks create --name test-cluster --resource-group test-rg --load-balancer-sku standard --ppg "/subscriptions/{subid}/resourceGroups/test-rg/providers/Microsoft.Compute/proximityPlacementGroups/test-ppg" --location centralus
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@tilnl tilnl requested a review from arrownj as a code owner October 8, 2020 14:15
@tilnl tilnl changed the title Add PPG support [AKS]Add PPG support Oct 8, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2020

AKS

@arrownj arrownj self-assigned this Oct 12, 2020
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arrownj
Copy link
Contributor

arrownj commented Oct 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@arrownj
Copy link
Contributor

arrownj commented Oct 14, 2020

Hi @tilnl , could you please fix the Automation Test failure ?

@tilnl
Copy link
Contributor Author

tilnl commented Oct 14, 2020 via email

@tilnl
Copy link
Contributor Author

tilnl commented Oct 15, 2020

@arrownj , test is fixed. Thanks!

@arrownj arrownj merged commit 1762d77 into Azure:dev Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants