[AppConfig] Fix querying key-values by comma separated labels #15449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you help to modify the command exmaples for using null label. Like add double quotes. #Resolved |
Member
Author
|
In reply to: 705803422 [](ancestors = 705803422)
I thought about adding that, but my concern is that its very specific to bash environment. We don't explicitly provide examples for bash anywhere else, and I think bash users would already know that any \ character needs to be escaped or enclosed in quotes. |
avanigupta
force-pushed
the
avanigupta/querymultiplelabels
branch
from
32ce74b to
44d0442
Compare
Member
Author
|
Hi @bim-msft , this PR is ready for review. |
Member
|
hi @bim-msft could you pls review the PR? thanks. |
bim-msft
approved these changes
Oct 19, 2020
Contributor
|
Ready for merging? @avanigupta |
Member
Author
|
@bim-msft , it's ready to merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #15440
Testing Guide
This PR will address the failure to retrieve key-values when multiple labels are provided for filtering, and one of those labels is null label \0:
az appconfig kv list -n <storename> --label \0,mylabelHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.