{Network} Fix dns loading issue in azure stack #15456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Network |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
2 tasks
haroldrandom
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue in https://dev.azure.com/azure-sdk/public/_build/results?buildId=557475&view=logs&j=b21ded15-2ef6-5c2b-875f-d00fdf573f12&t=293d8450-9e65-5c81-f34e-5d7d70fd3ffc.
The root cause is that for network module, the default resource type is MGMT_NETWORK and it is applied to
az network dnsif no addition specification.In previous profile, the issue doesn't happen because MGMT_NETWOR api version is lower than 2018-05-11. But in new 2020-09-01-hybrid profile, it is larger than 2018-05-01 and the command will be loaded but there is no such support in SDK, which will cause error as shown in CI.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.