{Docker} Rename local docker image tag #15463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
commented
Oct 9, 2020
Comment on lines
-125
to
-129
| For automated builds triggered by pushes to this repo, see [azuresdk/azure-cli-python](https://hub.docker.com/r/azuresdk/azure-cli-python/tags). | ||
| For example: | ||
| ```bash | ||
| $ docker run -u $(id -u):$(id -g) -v ${HOME}:/home/az -e HOME=/home/az --rm -it azuresdk/azure-cli-python:dev | ||
| ``` |
Member
Author
There was a problem hiding this comment.
This image has not been updated for over 2 years. This is no longer in the pipeline.
yungezz
approved these changes
Oct 10, 2020
Member
|
hi @fengzhou-msft how to test the change? |
Member
Author
Tested the changes in build_test branch: https://dev.azure.com/azure-sdk/public/_build/results?buildId=570345&view=results The tests for yum and deb packages have passed. |
haroldrandom
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We publish a legacy docker image
microsoft/azure-cliand a newmcr.microsoft.com/azure-cli. Meanwhile we use some docker images to build the Linux packages, these docker images are used only during packaging and not published. But they are using the same name as the published azure-cli images. To avoid confusion, this PR renames the docker images used for packaging.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.