[ARM] BREAKING CHANGE: Add user confirmation for az ts create #15480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stamp added to deployment_name, excess file removed in commit, launch,json reverted
Collaborator
|
ts |
added 3 commits
October 12, 2020 10:47
…TemplateSpecsIdempotency
…TemplateSpecsIdempotency
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…TemplateSpecsIdempotency
zhoxing-ms
reviewed
Oct 19, 2020
src/azure-cli/azure/cli/command_modules/resource/tests/latest/subscription_level_template.json
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Oct 19, 2020
Juliehzl
reviewed
Oct 19, 2020
detienne20
changed the title
Juliehzl
approved these changes
Oct 20, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
LGTM in general. Could you refine the title name with [ARM] not [ts]?
detienne20
changed the title
jsntcy
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a user confirmation flag to az ts create to account for the scenario where a user updates a template spec version via the create command; in that case the existing template spec version would be overwritten because create is not a patch like operation.
Testing Guide
{
ts create -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{template_file}" -d {display_name} --description {description} --version-description {version_description}
ts create -g {rg} -n {template_spec_name} -v 1.0 -f "{different_template_file}" --yes
}