{Packaging} Remove vcrpy as a dependency #15516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
changed the title
Member
|
hi @arrownj |
yungezz
reviewed
Oct 14, 2020
Member
yungezz
left a comment
yungezz
left a comment
There was a problem hiding this comment.
does need to remove from requirements.py3.windows?
Member
Author
It was not in requirements.py3.windows before. |
arrownj
approved these changes
Oct 16, 2020
jiasli
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vcrpyis only needed for testing, it should not be a dependency for theazure-clipackage.Testing Guide
Tested the packages built with this PR's changes in
build_testbranch: https://dev.azure.com/azure-sdk/public/_build/results?buildId=573786&view=results.History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.