Skip to content

Conversation

@qwordy
Copy link
Member

@qwordy qwordy commented Oct 16, 2020

Description

Resolve #15138
[Compute] sig image-definition create: add --features;

Testing Guide

az sig image-definition create -g fy4 --gallery-name gg1 --gallery-image-definition image --os-type linux -p publisher1 -f offer1 -s sku1 --features "IsSecureBootSupported=true IsMeasuredBootSupported=false"

History Notes

[Compute] sig image-definition create: add --features
[Compute] New API version of gallery_images 2020-09-30


This checklist is used to make sure that common guidelines for a pull request are followed.

@yungezz yungezz added the Compute az vm/vmss/image/disk/snapshot label Oct 19, 2020
@Azure Azure deleted a comment from yonzhan Oct 19, 2020
@yungezz
Copy link
Member

yungezz commented Oct 19, 2020

hi @arrownj could you pls review the PR?

Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jiasli jiasli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core LGTM.

@qwordy qwordy merged commit 0279655 into Azure:dev Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compute az vm/vmss/image/disk/snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GalleryImageDefinitionFeature to the SIG image definition object

4 participants