Skip to content

[DMS] Merging pg mysql from extension into core #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evelyn-ys merged 13 commits into from
Jan 15, 2021
Merged

[DMS] Merging pg mysql from extension into core #15746

evelyn-ys merged 13 commits into from
Jan 15, 2021

Conversation

@temandr
Copy link
Contributor

@temandr temandr commented Nov 1, 2020 •
edited by evelyn-ys
Loading

Description

  • Merging MySQL and PostgreSQL migration capability from the extension into the core. Since these scenarios have been in GA for a while, this change allows the customer to perform MySQL and PostgreSQL migrations (as well as cutover the migration) from the core cli package.

Testing Guide

No new tests added. Modified existing tests to test the scenario inputs for the MySQL and PostgreSQL scenarios.

History Notes

[DMS] BREAKING CHANGE: az dms project task create: Added mandatory task type parameter to help distinguish if a scenario is an online migration or an offline migration.
[DMS] az dms project task cutover: add new command which allows tasks with an online migration task type to cutover and end the migration.
[DMS] az dms project create/az dms project task create: Enable MySQL and PostgreSQL projects/tasks to be created.

This checklist is used to make sure that common guidelines for a pull request are followed.

@temandr temandr requested a review from haroldrandom as a code owner November 1, 2020 20:41
@temandr temandr changed the title Merge pg mysql core [DataMigration] Merge pg mysql core Nov 1, 2020
@temandr temandr changed the title [DataMigration] Merge pg mysql core [DataMigration] Merging pg mysql from extension into core Nov 1, 2020
@temandr temandr marked this pull request as draft November 1, 2020 21:21
@yonzhan yonzhan requested review from Juliehzl and jsntcy November 1, 2020 23:21
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 1, 2020

DataMigration

@yonzhan yonzhan requested a review from zhoxing-ms November 1, 2020 23:21
@yonzhan yonzhan added this to the S179 milestone Nov 1, 2020
@temandr temandr requested a review from vchske November 5, 2020 19:17
@yonzhan yonzhan modified the milestones: S179, S180 Dec 5, 2020
@temandr temandr marked this pull request as ready for review December 10, 2020 18:40
@temandr
Copy link
Contributor Author

temandr commented Dec 15, 2020

@yonzhan This is now ready for review. Please let me know if there are any questions or concerns.

@yonzhan yonzhan requested a review from evelyn-ys December 16, 2020 01:30
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 16, 2020

@evelyn-ys will help you with this PR.

@evelyn-ys evelyn-ys changed the title [DataMigration] Merging pg mysql from extension into core [DMS] Merging pg mysql from extension into core Dec 21, 2020
@yonzhan yonzhan modified the milestones: S180, S181 Dec 26, 2020
@evelyn-ys evelyn-ys removed the request for review from haroldrandom January 12, 2021 08:47
@evelyn-ys
Copy link
Member

evelyn-ys commented Jan 12, 2021

This pr may need more approvals. @Juliehzl Could you help review?

@Juliehzl
Copy link
Contributor

Juliehzl commented Jan 12, 2021

I am not the code owner. My approval is not useful. Please add codeowner in .github and then this PR could be merged.

Juliehzl
Juliehzl reviewed Jan 12, 2021
View reviewed changes
Juliehzl
Juliehzl reviewed Jan 12, 2021
View reviewed changes
src/azure-cli/azure/cli/command_modules/dms/custom.py

class ScenarioType(Enum):

def create_sql_connection_info(connection_info_json, prompt_prefix):
Copy link
Contributor

@Juliehzl Juliehzl Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing these code?

Copy link
Contributor Author

@temandr temandr Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was refactored into custom.create_connection.

@Juliehzl
Copy link
Contributor

Juliehzl commented Jan 12, 2021

Hi @temandr, may I know which extension is used for these commands previously? We may need to suppress the extension usage after migration.

@temandr temandr requested a review from msyyc as a code owner January 12, 2021 18:59
@temandr
Copy link
Contributor Author

temandr commented Jan 12, 2021 •
edited
Loading

Hi @temandr, may I know which extension is used for these commands previously? We may need to suppress the extension usage after migration.

https://github.com/Azure/azure-cli-extensions/tree/master/src/dms-preview
Although not all features are being migrated; so, after this is checked in, I will work on removing the migrated features.

@temandr temandr requested a review from binuj January 13, 2021 22:14
@Juliehzl
Copy link
Contributor

Juliehzl commented Jan 15, 2021

@msyyc as you are the code owner, we need your approval to merge the PR.

@evelyn-ys evelyn-ys merged commit 8930324 into Azure:dev Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Juliehzl left review comments

@evelyn-ys evelyn-ys evelyn-ys approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@vchske vchske Awaiting requested review from vchske

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@binuj binuj Awaiting requested review from binuj

+1 more reviewer

@msyyc msyyc msyyc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@evelyn-ys evelyn-ys

@binuj binuj

Labels

None yet

Projects

None yet

Milestone

S181

Development

Successfully merging this pull request may close these issues.

6 participants

@temandr @yonzhan @evelyn-ys @Juliehzl @msyyc @binuj