-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ACR] bump api version. support zone redundancy #15975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hi @fengzhou-msft could you pls help to review? |
yungezz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls not checkin binary file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls help to make sure run full live test for regression. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-run tests, please can you review @yungezz
|
@yungezz thanks for the heads up and review. This is a wip pr with the generated sdk. I will remove it when the sdk has been published. I will also make sure to run a full live test locally to ensure no regressions with the new api version. |
5e76392 to
7ad595e
Compare
|
@yungezz @fengzhou-msft please can your review? i am hoping to make next week's code complete. Moreover some acr tests are broken because networking command loading / parameter registration is having issues. I have latest dev. This section in network/_params.py is causing problems: this happens when tests like the one here try to create a vnet: |
|
@jsntcy for awareness. |
As we're migrating network to track2 SDK, hopefully the migration can be done by the end of this week and will check if this issue still exists after migration. |
|
LGTM |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yungezz please can you reapprove and merge when ready. I am no longer adding the |
955aa71 to
dca81fd
Compare
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.