[AKS] Add support for AGIC addon #15993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
AKS |
Contributor
|
Hi @fengzhou-msft , could you please also help review this PR ? Thanks |
akshaysngupta
force-pushed
the
aksgupta/addon
branch
from
ae0e15e to
c66fe7f
Compare
akshaysngupta
force-pushed
the
aksgupta/addon
branch
from
c66fe7f to
942aa12
Compare
fengzhou-msft
approved these changes
Nov 26, 2020
norshtein
reviewed
Nov 26, 2020
| {}, | ||
| workspace_resource_id, | ||
| aci_subnet_name, | ||
| vnet_subnet_id |
Member
There was a problem hiding this comment.
Here, two parameters are removed by mistake, so later appgw related parameters are not aligned.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.