Skip to content

[Role] az ad sp create-for-rbac: Deprecate creating Contributor role assignment by default #16081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 7 commits into from
Dec 22, 2020
+25 −13
Merged

[Role] az ad sp create-for-rbac: Deprecate creating Contributor role assignment by default #16081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f27078e
Deprecate creating role assignment
jiasli Nov 30, 2020
9040722
Merge branch 'dev' into sp-role
jiasli Nov 30, 2020
c15ae85
Merge branch 'dev' into sp-role
jiasli Dec 2, 2020
93e36a9
style
jiasli Dec 2, 2020
cf1606b
Update src/azure-cli/azure/cli/command_modules/role/custom.py
jiasli Dec 17, 2020
a803c62
Refine message
jiasli Dec 17, 2020
fa68140
Wording
jiasli Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refine message
  • Loading branch information
@jiasli
jiasli committed Dec 17, 2020
commit a803c6206818b00a889276787f10868fe6a2851b
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,8 @@
See [steps to add a role assignment](https://aka.ms/azadsp-more) for more information.


WARNING: In a future release, this command will NOT create any role assignment by default. (--skip-assignment will be the
default behavior.) If needed, always use --role to explicitly create a role assignment.
WARNING: In a future release, this command will NOT create 'Contributor' role assignment by default.
If needed, always use --role to explicitly create a role assignment.
parameters:
- name: --name -n
short-summary: A URI to use as the logic name. It doesn't need to exist. If not present, CLI will generate one.
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"your code or check the credentials into your source control. For more information, see https://aka.ms/azadsp-cli")

ROLE_ASSIGNMENT_CREATE_WARNING = (
"In a future release, this command will NOT create a role assignment by default. (--skip-assignment will be the "
"default behavior.) If needed, always use --role to explicitly create a role assignment."
"In a future release, this command will NOT create 'Contributor' role assignment by default. "
"If needed, always use --role to explicitly create a role assignment."
)

logger = get_logger(__name__)
Expand Down