Skip to content

Conversation

@azclibot
Copy link
Collaborator

@azclibot azclibot commented Dec 1, 2020

This PR is created by AladdinParser Pipeline.

ADO_BUILD_ID=637130

Against last commit of dev: e5e197d10

Against last commit of Aladdin-src: 318dff2

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 1, 2020

Aladdin

@yonzhan yonzhan added this to the S179 milestone Dec 1, 2020
@yonzhan yonzhan requested review from jsntcy and kairu-ms December 1, 2020 08:32
@haroldrandom haroldrandom marked this pull request as ready for review December 1, 2020 08:56
@haroldrandom haroldrandom requested a review from houk-ms as a code owner December 9, 2020 02:31
text: |
az network traffic-manager profile update --name MyTmProfile --resource-group MyResourceGroup --status Enabled
crafted: true
- name: Update a traffic manager profile. (autogenerated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we allow delete existing one when this is no duiplicate?

Copy link
Contributor

@haroldrandom haroldrandom Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Aladdin want us to do so. The example they provide is a full set

@haroldrandom
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haroldrandom haroldrandom merged commit 84e0e45 into Azure:dev Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants