-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ARM] az ts: Add support for --tags #16149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
ARM |
Juliehzl
reviewed
Dec 8, 2020
zhoxing-ms
reviewed
Dec 8, 2020
zhoxing-ms
reviewed
Dec 8, 2020
zhoxing-ms
approved these changes
Dec 14, 2020
Juliehzl
reviewed
Dec 15, 2020
Juliehzl
reviewed
Dec 15, 2020
| examples: | ||
| - name: Create a template spec. | ||
| text: az ts create -g testRG --name TemplateSpecName -l WestUS --display-name "MyDisplayName" --description "Simple template spec" | ||
| text: az ts create -g testRG --name TemplateSpecName -l WestUS --display-name "MyDisplayName" --description "Simple template spec" --tag key1=value1 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| text: az ts create -g testRG --name TemplateSpecName -l WestUS --display-name "MyDisplayName" --description "Simple template spec" --tag key1=value1 | |
| text: az ts create -g testRG --name TemplateSpecName -l WestUS --display-name "MyDisplayName" --description "Simple template spec" --tags key1=value1 |
Juliehzl
reviewed
Dec 15, 2020
| - name: Update the description of a template spec version. | ||
| text: az ts update -g ExistingRG --name ExistingName -v 3.0 --version-description "New description" | ||
| - name: Update the display name and tag(s) of a template spec based on the resource ID. | ||
| text: az ts update --template-spec resourceID --display-name "NewParentDisplayName" --tag key1=value1 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| text: az ts update --template-spec resourceID --display-name "NewParentDisplayName" --tag key1=value1 | |
| text: az ts update --template-spec resourceID --display-name "NewParentDisplayName" --tags key1=value1 |
Juliehzl
approved these changes
Dec 16, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Template Specs create and update now supports --tags.
Testing Guide
(1)
az ts create -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --tag cli-test=test
(2)
az ts create -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}"
(3a.)
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --tags --yes
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --tags "" --yes
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --tags '' --yes
(3b.)
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --yes
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --yes
az ts update -g {rg} -n {template_spec_name} -v 1.0 -l {resource_group_location} -f "{tf}" --yes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.