Skip to content

Conversation

@detienne20
Copy link
Contributor

SDK upgraded to allow support for query string parameter for deployments (Model TemplateLink has a new parameter query_string)

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 7, 2020

ARM

@zhoxing-ms
Copy link
Contributor

@detienne20 I see the description in pypi.org that there are some breaking changes in the Python SDK of version 11.0.0
Could you please run the test of resource module again in live mode?

@detienne20 detienne20 changed the title {ARM} Bump azure-mgmt-resource SDK from 10.3.0 to 11.0.0 {ARM} Bump azure-mgmt-resource SDK: 10.3.0 to 12.0.0, v2020-06-01 to v2020-10-01 Dec 16, 2020
@yonzhan yonzhan added this to the S181 milestone Dec 16, 2020
Dania Etienne added 6 commits December 21, 2020 11:11
…TestAtTenantScopeWhatIf ,TenantScopeDeployment, DeploymentWhatIfAtManagementGroupTest, DeploymentTestAtManagementGroup, ManagedAppScenarioTest, ManagedAppDefinitionScenarioTest
…_built_in_policy, the tests that where marked skipped during this process have been restored (.yaml files that is)
… to keep sub branches updated and allow work to be done in parallel.
@zhoxing-ms
Copy link
Contributor

What is loa1.pdf? Can we delete it?

Copy link
Member

@qwordy qwordy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code change in VM part.

@detienne20
Copy link
Contributor Author

detienne20 commented Jan 4, 2021

What is loa1.pdf? Can we delete it?

@zhoxing-ms Yes I will delete it. It was generated automatically while recording the tests.

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for ARM part

@msyyc
Copy link
Member

msyyc commented Jan 5, 2021

No code change in network part

Copy link

@v-Ajnava v-Ajnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aim-for-better aim-for-better left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The impact for HDInsight is test files. I think it is ok. LGTM

@zhoxing-ms zhoxing-ms merged commit 4ac1441 into Azure:dev Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.