[Compute] vm/vmss extension set: New parameter --enable-auto-upgrade #16243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Compute |
| help='Name of the extension.', id_part=None) | ||
| c.argument('force_update', action='store_true', help='force to update even if the extension configuration has not changed.') | ||
| c.argument('extension_instance_name', extension_instance_name_type) | ||
| c.argument('enable_automatic_upgrade', options_list=['--enable-automatic-upgrade', '-a'], action='store_true', help='Indicate the extension should be automatically upgraded by the platform if there is a newer version of the extension available.') |
Member
There was a problem hiding this comment.
Is there a way to disable it after it's enabled?
Member
Author
There was a problem hiding this comment.
vm extension does not support update. We can set it again.
qwordy
changed the title
qwordy
changed the title
yungezz
suggested changes
Dec 21, 2020
Member
yungezz
left a comment
yungezz
left a comment
There was a problem hiding this comment.
could you pls share rationale behind the breaking change
Member
Author
|
The parameter names are confusing. So I give it a new name. Given the usage statistics, do you think we can make a breaking change? I can revert it if you are worry about the impact to users. @yungezz |
yungezz
reviewed
Jan 4, 2021
qwordy
changed the title
yungezz
approved these changes
Jan 8, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #16160
New parameter in vm/vmss extension set
Change
--no-auto-upgradeto--no-auto-upgrade-minor-versionto avoid confusion.Usage statistics in 30 days:
592 invocations,
vm extensionwith--no-auto-upgrade113 invocations,
vmss extensionwith--no-auto-upgrade665640 invocations,
vm extension26701 invocations,
vmss extensionTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.