[AppService] Fixes #14583: az webapp up should generate default name if name isn't provided #16267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinsID
force-pushed
the
webapp-up-default-name
branch
from
d5b9630 to
f3f3184
Compare
calvinsID
force-pushed
the
webapp-up-default-name
branch
from
f3f3184 to
d6ce090
Compare
Collaborator
|
AppService |
Member
|
Some checks were not successful. Credential found! If you confirm it is not a real credential, add the file name to scripts/ci/credscan/CredScanSuppressions.json |
qwordy
reviewed
Dec 15, 2020
| ]) | ||
|
|
||
| # test changing runtime to newer version | ||
| time.sleep(30) |
qwordy
approved these changes
Dec 15, 2020
panchagnula
reviewed
Dec 15, 2020
src/azure-cli/azure/cli/command_modules/appservice/_constants.py
Outdated
Show resolved
Hide resolved
Contributor
|
Should we fix this issue as a part of this PR as well? #16266 |
panchagnula
suggested changes
Dec 15, 2020
Contributor
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
Please see comments for requested changes.
calvinsID
requested review from
fengzhou-msft and
haroldrandom
as code owners
calvinsID
force-pushed
the
webapp-up-default-name
branch
from
d602fb3 to
086e0d3
Compare
Contributor
Author
I couldn't find a consistent repro, so will need to spend more time figuring why the issue happens periodically. I'll do it in a separate PR |
qwordy
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
--nameparameter optional for commandaz webapp upIf name isn't provided, generate default name in the format adjective-noun-guid, ex. zealous-tree-06c552e1e
Also fixes WebApp:unexpected -l #16185 documentation update
Testing Guide
az webapp upwithout parameters in a directory you want to deployThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.