{Error Handling} Show explicit error messages for HttpOperationError #16273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix the issue Azure/azure-cli-extensions#2793.
For
HttpOperationError, we can find its error message either inHttpOperationError.response.textandHttpOperationError.message. E.g, for the case above, the error message inHttpOperationError.messageisand the error message in
HttpOperationError.response.textis like below, which is more explicitPreviously in AzureCLI core, the exception handler firstly tries to parse the
HttpOperationError.response.text(usually a dict), and when that fails, it falls back to useHttpOperationError.message.While the problem is the
HttpOperationError.response.textis not a standard structure to parse, so we have to try to parse it according to the possible response structures. It means that we may also get a response like thisTesting Guide
For the issue above, follow the reproducing steps there
Previously, you'll get the error message
Now, you will get the error messgae