Skip to content

Conversation

@fengzhou-msft
Copy link
Member

Description

Edge build is broken as pip now compares the version in the wheel package name and the version in Metadata. Previously, we only added .post1 in package name. This PRs changes the version in source code with .post1 suffix as well when building packages for non-release branch code. This also helps us identify requests from edge builds in telemetry data.

CI is broken as azure-cli-core previously pinned azure-cli-telemetry to 1.0.6 while in CI 1.0.6.devxxx is installed. Latest pip will throw an error. This PR changes the dependency version to azure-cli-telemetry==1.0.6.*.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

from setuptools import setup
VERSION = "1.0.0.dev$version"
VERSION = "1.0.0.post1"
Copy link
Member

@jiasli jiasli Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this change for CI (I don't think it matters what version to use in CI as it will not be released.), but refactored to put dev inside $version and for edge built python wheel $version is changed to postN.

With the increasing number of unexpected hot fix release, it may not be a good idea to bump version right after a release and use devN for edge build versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the increasing number of unexpected hot fix release, it may not be a good idea to bump version right after a release and use devN for edge build versions.

I think hotfix PRs will target release branch, which still has the last version, like 2.16.0, even though the dev branch is now at 2.17.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss about this in our next release meeting. The CI in azure-cli-extensions repo is broken now, let's merge this PR to unblock it first. If we decided to use dev version, we can start to do it after the next release.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 17, 2020

Packaging

@fengzhou-msft fengzhou-msft marked this pull request as draft December 18, 2020 01:09
@fengzhou-msft fengzhou-msft marked this pull request as ready for review December 21, 2020 06:18
Copy link
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require a test PR/a test result for BuldPythonWheel and Automation Test and full test

@fengzhou-msft fengzhou-msft mentioned this pull request Dec 21, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants