-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Packaging} Fix version to conform to pip 20.3 #16302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scripts/ci/build.sh
Outdated
| from setuptools import setup | ||
| VERSION = "1.0.0.dev$version" | ||
| VERSION = "1.0.0.post1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't 1.0.1.devN be more feasible? https://www.python.org/dev/peps/pep-0440/#developmental-releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted this change for CI (I don't think it matters what version to use in CI as it will not be released.), but refactored to put dev inside $version and for edge built python wheel $version is changed to postN.
With the increasing number of unexpected hot fix release, it may not be a good idea to bump version right after a release and use devN for edge build versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the increasing number of unexpected hot fix release, it may not be a good idea to bump version right after a release and use
devNfor edge build versions.
I think hotfix PRs will target release branch, which still has the last version, like 2.16.0, even though the dev branch is now at 2.17.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss about this in our next release meeting. The CI in azure-cli-extensions repo is broken now, let's merge this PR to unblock it first. If we decided to use dev version, we can start to do it after the next release.
|
Packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require a test PR/a test result for BuldPythonWheel and Automation Test and full test
Description
Edge build is broken as pip now compares the version in the wheel package name and the version in Metadata. Previously, we only added
.post1in package name. This PRs changes the version in source code with.post1suffix as well when building packages for non-release branch code. This also helps us identify requests from edge builds in telemetry data.CI is broken as
azure-cli-corepreviously pinnedazure-cli-telemetryto1.0.6while in CI1.0.6.devxxxis installed. Latest pip will throw an error. This PR changes the dependency version toazure-cli-telemetry==1.0.6.*.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.